RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v4]
Volkan Yazici
vyazici at openjdk.org
Tue Feb 4 14:29:13 UTC 2025
On Tue, 4 Feb 2025 10:47:22 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Assert that multiple files can be served using the same `FileServerHandler`
>> - Remove redundant `@build` dependencies
>
> test/jdk/com/sun/net/httpserver/SelCacheTest.java line 145:
>
>> 143: fout.close();
>> 144:
>> 145: if (count != filePath.toFile().length()) {
>
> Maybe we could use assertEquals here for better diagnosability
Fixed in 9c7c6af013e0495b08bcd248e30d83385bcc35b5.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23401#discussion_r1941277359
More information about the core-libs-dev
mailing list