RFR: 8346567: Make Class.getModifiers() non-native [v2]

[Coleen Phillimore]

On Tue, 4 Feb 2025 13:36:44 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix copyright and param name
>
> src/hotspot/share/oops/arrayKlass.hpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 1997, 2025, Oracle and/or its affiliates. All rights reserved.
> 
> arrayKlass.hpp isn't changed, is this left over from a previous iteration?

yes, it was something that my copyright script thought I changed from merging some previous changes.

> src/java.base/share/classes/java/lang/Class.java line 244:
> 
>> 242:         classLoader = loader;
>> 243:         componentType = arrayComponentType;
>> 244:         modifiers = dummyModifiers;
> 
> I realize this ctor isn't used but "dummyModifiers" looks very strange as parameter name when compared to the others, renaming it to something like "mods" would make it less confusing for anyone reading through this code.

I changed it to mods.  Thanks for the suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22652#discussion_r1941301152
PR Review Comment: https://git.openjdk.org/jdk/pull/22652#discussion_r1941302820