RFR: 8346434: Add test for non-automatic service binding
Alexander Matveev
almatvee at openjdk.org
Wed Feb 5 03:28:19 UTC 2025
On Fri, 10 Jan 2025 21:23:22 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
> Added a test case to JLinkOptionsTest to test that jpackage doesn't bind services in app's runtime by default.
>
> The test builds two app images for the same app. One with the default jlink options and another with `--bind-services` jlink option. The test compares module lists from both runtimes. The expected result is that the runtime built with `--bind-services` jlink option has additional modules.
>
> The PR must be integrated after https://github.com/openjdk/jdk/pull/22644. Otherwise, the newly added test will fail.
test/jdk/tools/jpackage/share/JLinkOptionsTest.java line 175:
> 173: .setExecutable(cmd.appLauncherPath().toAbsolutePath())
> 174: .addArguments("--print-modules")
> 175: .executeAndRepeatUntilExitCode(0, attempts,
Is there any reason why we need to repeat execution?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23047#discussion_r1942195448
More information about the core-libs-dev
mailing list