RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret
Alan Bateman
alanb at openjdk.org
Wed Feb 5 14:21:16 UTC 2025
On Wed, 5 Feb 2025 10:20:11 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR proposes to add some `@ForceInline` annotations in the `Module` class in order to assist inlining of FFM var/method handles.
>>
>> Tested and passed tier1-3
>
> src/java.base/share/classes/java/lang/Module.java line 488:
>
>> 486: // if other is an unnamed module then check if this module reads
>> 487: // all unnamed modules
>> 488: return !other.isNamed()
>
> This is a drive-by simplification.
Can you revert this, the original code was easier to read.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23460#discussion_r1943023700
More information about the core-libs-dev
mailing list