RFR: 8344925: translet-name ignored when package-name is also set [v2]

Joe Wang joehw at openjdk.org
Thu Feb 6 20:19:53 UTC 2025


On Thu, 6 Feb 2025 18:04:47 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update test
>
> test/jaxp/javax/xml/jaxp/libs/jaxp/library/JUnitTestUtil.java line 33:
> 
>> 31:     public static final String CLS_DIR = System.getProperty("test.classes");
>> 32:     public static final String SRC_DIR = System.getProperty("test.src");
>> 33:     public static final boolean isWindows = System.getProperty("os.name").contains("Windows");
> 
> It is good as it stands, but Platform.isWindows() can be used here

Updated using the test lib. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23446#discussion_r1945367084


More information about the core-libs-dev mailing list