RFR: 8349564: Clean warnings found in jpackage tests when building them with -Xlint:all [v2]

[Alexey Semenyuk]

On Thu, 6 Feb 2025 22:50:23 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> do we need to add -Xlint:all -Werror as well when building helper classes?

Good question. They are implicitly built by jtreg when requested through `@build jdk.jpackage.test.*` tag. I don't know how it constructs javac command line. @sormuras can you comment?

> test/jdk/tools/jpackage/share/JavaOptionsTest.java line 39:
> 
>> 37:  * @library /test/jdk/tools/jpackage/helpers
>> 38:  * @build jdk.jpackage.test.*
>> 39:  * @compile -Xlint:all -Werror JavaOptionsTest.java
> 
> Can we add `-Xlint:all -Werror` in generic way instead of repeating each time?

I don't think so.
@sormuras does jtreg allow to keep javac args for a group of tests in one place?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23455#discussion_r1945603281
PR Review Comment: https://git.openjdk.org/jdk/pull/23455#discussion_r1945601807