RFR: 8349648: Test tools/jpackage/share/JLinkOptionsTest.java fails with --enable-linkable-runtime set after JDK-8346434

[Alexey Semenyuk]

On Fri, 7 Feb 2025 17:08:06 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> test/jdk/tools/jpackage/share/JLinkOptionsTest.java line 145:
>> 
>>> 143:     public void testNoBindServicesByDefault() {
>>> 144:         final var defaultModules = getModulesInRuntime("--limit-modules java.smartcardio,jdk.crypto.cryptoki,java.desktop");
>>> 145:         final var modulesWithBindServices = getModulesInRuntime("--bind-services --limit-modules java.smartcardio,jdk.crypto.cryptoki,java.desktop");
>> 
>> Pre-existing: It would be good to document which additional modules in the set get dragged in by `--bind-services`. That would allow future readers of that test to figure out why a test starts to fail (e.g. by a future change removing a provided service in a module).
>
> As far as my testing is concerned it's only `jdk.crypto.cryptoki` which is different with `--bind-services` (as it provides a security provider as a service and doesn't export API).

This is the diff of modules between "jpackage without --bind-services" and "jpackage with --bind-services" before this PR:

[20:27:10.849] TRACE: assertNotEquals(, jdk.charsets,jdk.crypto.cryptoki,jdk.crypto.mscapi,jdk.editpad,jdk.jdeps,jdk.jlink,jdk.jpackage,jdk.jstatd,jdk.localedata,jdk.naming.dns,jdk.naming.rmi): Check '--bind-services' option adds modules

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23514#discussion_r1946924600