RFR: 8349620: Add VMProps for static JDK
Alan Bateman
alanb at openjdk.org
Mon Feb 10 08:24:10 UTC 2025
On Fri, 7 Feb 2025 23:51:41 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
> Please review this change that adds the `jdk.static` VMProps. It can be used to skip tests not for running on static JDK.
>
> This also adds a new WhiteBox native method, `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by VMProps to determine if it's static at runtime.
>
> `@requires !jdk.static` is added in `test/hotspot/jtreg/runtime/modules/ModulesSymLink.java` to skip running the test on static JDK. This test uses `bin/jlink`, which is not provided on static JDK. There are other tests that require tools in `bin/`. Those are not modified by the current PR to skip running on static JDK. Those can be done after the current change is fully discussed and reviewed/approved.
I think this looks okay, I'm just wondering is one property is enough to cover all the configurations.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23528#issuecomment-2647241299
More information about the core-libs-dev
mailing list