RFR: 8344168: Change Unsafe base offset from int to long [v7]

Doug Simon dnsimon at openjdk.org
Mon Feb 10 17:11:17 UTC 2025


On Thu, 30 Jan 2025 00:37:16 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> The type of the Unsafe base offset constant is int, which may cause overflow when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027) fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are still unfixed.
>> 
>> @liach proposed the idea of ​​changing the Unsafe base offset to long, which is a complete solution to the Unsafe offset overflow. After discussing with @liach, I submitted this PR to implement @liach's idea.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   copyright

I'm curious why `arrayOopDesc::base_offset_in_bytes` was not included in this change - does it not face the same overflow problem?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22095#issuecomment-2648702248


More information about the core-libs-dev mailing list