RFR: 8349624: Validation for slot missing in CodeBuilder local variable instructions
Adam Sotona
asotona at openjdk.org
Tue Feb 11 07:56:10 UTC 2025
On Fri, 7 Feb 2025 19:40:44 GMT, Chen Liang <liach at openjdk.org> wrote:
> In CodeBuilder, validation for a slot was missing due to concurrent patches, and the original patch did not add effective tests for CodeBuilder because of the complex exceptional behaviors. Now the bug is fixed with renames to prevent future risky usages, and the tests have been enhanced to ensure at least the failure-case behavior (while the non-failure case is harder to check due to exceptional behaviors)
>
> Testing: JDK tier 1-3
Looks good to me.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23522#pullrequestreview-2607934748
More information about the core-libs-dev
mailing list