RFR: 8349689: Several virtual thread tests missing /native keyword [v3]
Alan Bateman
alanb at openjdk.org
Tue Feb 11 08:56:11 UTC 2025
On Tue, 11 Feb 2025 08:44:15 GMT, SendaoYan <syan at openjdk.org> wrote:
>> test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java line 69:
>>
>>> 67: if (flag != true) {
>>> 68: throw new RuntimeException("flag = " + flag);
>>> 69: }
>>
>> What are these other changes about?
>
> Reason description as https://github.com/openjdk/jdk/pull/23550#issuecomment-2650141187.
Can you remove this change from the PR as it this is a separate discussion? My guess is that in your environment the Thread.yield is somehow taking more than 5 seconds, is that right? In that case, we can modify the test to use a latch to ensure that it loops at least once. Anyway, separate issue, we shouldn't include it in this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23550#discussion_r1950452441
More information about the core-libs-dev
mailing list