RFR: 8344802: Crash in StubRoutines::verify_mxcsr with -XX:+EnableX86ECoreOpts and -Xcheck:jni [v6]

Volodymyr Paprotski vpaprotski at openjdk.org
Wed Feb 12 15:47:07 UTC 2025


On Wed, 12 Feb 2025 15:38:34 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Volodymyr Paprotski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments from Sandhya
>
> src/hotspot/os/windows/os_windows.cpp line 2757:
> 
>> 2755: 
>> 2756: #if defined(_M_AMD64)
>> 2757:     extern bool handle_FLT_exception(struct _EXCEPTION_POINTERS* exceptionInfo);
> 
> This seems strange to declare inside another method like this, not a showstopper but it might be better to declare it where handle_FLT_exception used to be defined in this file

Oh.. I remember wondering where to put this. Meant to come back and find the right header

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22673#discussion_r1952907016


More information about the core-libs-dev mailing list