RFR: 8349907: jdk.tools.jlink.internal.plugins.ZipPlugin does not close the Deflater in exceptional cases [v2]

[Jaikiran Pai]

On Wed, 12 Feb 2025 15:45:53 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Lance's suggestion
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ZipPlugin.java line 99:
> 
>> 97:             return stream.toByteArray(); // the compressed output
>> 98:         } catch (IOException e) {
>> 99:             return bytesIn; // return the original uncompressed input
> 
> Can we add an `assert false : e;` assertion because this really shouldn't happen?

I have updated the PR to add that assert and added a brief comment why we have it there. tier testing with this updated change is currently in progress.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23588#discussion_r1953039423