RFR: 8349759: Fix CertificateBuilder and SimpleOCSPServer test utilities to support PQC algorithms [v3]

Sean Mullan mullan at openjdk.org
Fri Feb 14 14:33:10 UTC 2025


On Thu, 13 Feb 2025 22:43:39 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:

>> test/lib/jdk/test/lib/security/CertificateBuilder.java line 462:
>> 
>>> 460:             throws CertificateException, IOException, NoSuchAlgorithmException {
>>> 461: 
>>> 462:         AlgorithmId signAlg;
>> 
>> This variable looks like it is unused now.
>
> It's used on 476 for encoding the AlgorithmIdentifier of the certificate signature, and also on 530 to again provide that same AlgorithmIdentifier encoding in the TBSCertificate strructure.

You mean lines 458 and 466? Yes, I missed that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23566#discussion_r1956240646


More information about the core-libs-dev mailing list