RFR: 8350098: jpackage test lib erroneously will run methods without @Test annotation as tests

Alexander Matveev almatvee at openjdk.org
Fri Feb 14 22:48:10 UTC 2025


On Fri, 14 Feb 2025 14:30:25 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

> Don't consider functions without `jdk.jpackage.test.Annotations.Test` annotation as tests.
> 
> Additionally, enhance the functionality of `jdk.jpackage.test.Annotations.ParameterSupplier` annotation: make an empty string the default value. If the method name is empty (the default annotation value), then the name of the parameter supplier method is the same as the name of the annotated method. E.g.: `@Test @ParameterSupplier public void testInteger(int v)` is equivalent to `@Test @ParameterSupplier("testInteger") public void testInteger(int v)`.

Looks good.

-------------

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23632#pullrequestreview-2618944131


More information about the core-libs-dev mailing list