RFR: 8349620: Add VMProps for static JDK [v2]
Jiangli Zhou
jiangli at openjdk.org
Wed Feb 19 00:31:55 UTC 2025
On Wed, 19 Feb 2025 00:06:52 GMT, Man Cao <manc at openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8349620
>> - - Add 'jdk.static' in VMProps. It can be used to skip tests not for running on static JDK.
>> - Add WhiteBox isStatic() native method. It's used by VMProps to determine of it's static at runtime.
>> - Add in '@requires !jdk.static' in test/hotspot/jtreg/runtime/modules/ModulesSymLink.java to skip the test on static JDK since it requires bin/jlink.
>
> Changes look good.
>
>> I'm also wondering if we would want to merge the isStatic into isHermetic check in the future.
>
> I guess it is unlikely we will package each jtreg test into single, hermetic files, each containing the whole JDK? If so, we probably won't need `isHermetic` for jtreg tests.
@caoman Thanks for reviewing!
> > I'm also wondering if we would want to merge the isStatic into isHermetic check in the future.
>
> I guess it is unlikely we will package each jtreg test into single, hermetic files, each containing the whole JDK? If so, we probably won't need `isHermetic` for jtreg tests.
When hermetic is supported, I think we will want to add new tests to explicitly exercise packaging a single executable image including the runtime and run using the single image. Those would be dedicated tests, instead of testing all/most jtreg tests in hermetic mode. `isHermetic` could be useful when we add such tests.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23528#issuecomment-2667226529
More information about the core-libs-dev
mailing list