RFR: 8349943: [JMH] Use jvmArgs consistently
Nicole Xu
duke at openjdk.org
Thu Feb 20 01:30:58 UTC 2025
On Thu, 13 Feb 2025 20:04:05 GMT, Chen Liang <liach at openjdk.org> wrote:
>> As is suggested in [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should be used consistently in microbenchmarks to 'align with the intuition that when you use jvmArgsAppend/-Prepend intent is to add to a set of existing flags, while if you supply jvmArgs intent is "run with these and nothing else"'.
>>
>> All the previous flags were aligned in https://github.com/openjdk/jdk/pull/21683, while some recent tests use inconsistent `jvmArgs` again. We update them to keep the consistency.
>
> The java.lang.foreign arg changes look fine.
@liach @sendaoYan @cl4es Thanks for your review. I'm going to integrate the patch.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23609#issuecomment-2670174332
More information about the core-libs-dev
mailing list