RFR: 8349943: [JMH] Use jvmArgs consistently
Hao Sun
haosun at openjdk.org
Thu Feb 20 01:36:56 UTC 2025
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu <duke at openjdk.org> wrote:
> As is suggested in [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should be used consistently in microbenchmarks to 'align with the intuition that when you use jvmArgsAppend/-Prepend intent is to add to a set of existing flags, while if you supply jvmArgs intent is "run with these and nothing else"'.
>
> All the previous flags were aligned in https://github.com/openjdk/jdk/pull/21683, while some recent tests use inconsistent `jvmArgs` again. We update them to keep the consistency.
This patch has been reviewed and tested internally.
GHA tests are all green. Let me sponsor it.
-------------
Marked as reviewed by haosun (Committer).
PR Review: https://git.openjdk.org/jdk/pull/23609#pullrequestreview-2628468812
More information about the core-libs-dev
mailing list