RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v18]

[Jatin Bhateja]

On Tue, 18 Feb 2025 02:36:13 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Is anyone else getting compile failures after this was integrated? This weirdly seems to only happen on Linux
> 
> ```
> * For target hotspot_variant-server_libjvm_objs_mulnode.o:
> /home/runner/work/jdk/jdk/src/hotspot/share/opto/mulnode.cpp: In member function ‘virtual const Type* FmaHFNode::Value(PhaseGVN*) const’:
> /home/runner/work/jdk/jdk/src/hotspot/share/opto/mulnode.cpp:1944:37: error: call of overloaded ‘make(double)’ is ambiguous
>  1944 |   return TypeH::make(fma(f1, f2, f3));
>       |                                     ^
> In file included from /home/runner/work/jdk/jdk/src/hotspot/share/opto/node.hpp:31,
>                  from /home/runner/work/jdk/jdk/src/hotspot/share/opto/addnode.hpp:28,
>                  from /home/runner/work/jdk/jdk/src/hotspot/share/opto/mulnode.cpp:26:
> /home/runner/work/jdk/jdk/src/hotspot/share/opto/type.hpp:544:23: note: candidate: ‘static const TypeH* TypeH::make(float)’
>   544 |   static const TypeH* make(float f);
>       |                       ^~~~
> /home/runner/work/jdk/jdk/src/hotspot/share/opto/type.hpp:545:23: note: candidate: ‘static const TypeH* TypeH::make(short int)’
>   545 |   static const TypeH* make(short f);
>       |                       ^~~~
> ```

Hi @TheShermanTanker , 

Please file a separate JBS issue for the errors you are observing with non-standard build options. 
I am also seeing some other build issues with the following configuration
--with-extra-cxxflags=-D__CORRECT_ISO_CPP11_MATH_H_PROTO_FP

Best Regards,
Jatin

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22754#issuecomment-2671231948