RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v11]

Sergey Chernyshev schernyshev at openjdk.org
Thu Feb 20 17:36:04 UTC 2025


On Mon, 17 Feb 2025 11:09:12 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Sergey Chernyshev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added details in the log message
>
> src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1SubsystemController.java line 73:
> 
>> 71:                                 break;
>> 72:                             }
>> 73:                             cgp = (cgp.getNameCount() > 1) ? cgp.subpath(1, cgp.getNameCount()) : Path.of("");
> 
> Suggestion:
> 
>                             cgp = (nameCount > 1) ? cgp.subpath(1, nameCount) : Path.of("");

Good catch, but as long as cgp#nameCount may change in the loop, this exact patch i cannot take.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21808#discussion_r1964064662


More information about the core-libs-dev mailing list