RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd [v2]

Joe Wang joehw at openjdk.org
Fri Feb 21 17:27:52 UTC 2025


On Fri, 21 Feb 2025 01:38:34 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> 
>> Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes unexpectedly when missing the depentdent file test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a NULL check after call `getResourceAsStream("CR6740048.xsd")`.
>> 
>> This PR do not change the original test logic but make test more robustness. Change has been verified locally, test-fix only, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove the conditional check that verifies its existence

Thanks.

-------------

Marked as reviewed by joehw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23627#pullrequestreview-2633771314


More information about the core-libs-dev mailing list