RFR: 8349759: Add unit test for CertificateBuilder and SimpleOCSPServer test utilities [v4]

Sean Mullan mullan at openjdk.org
Fri Feb 21 19:55:57 UTC 2025


On Thu, 20 Feb 2025 01:12:46 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:

>> This fix makes some minor changes to the internals of the `CertificateBuilder` and `SimpleOCSPServer` test classes.  They would break when ML-DSA was selected as key and signing algorithms.  Also RSASSA-PSS works better now with these changes.  I've also taken this opportunity to do some cleanup on CertificateBuilder and added a method which uses a default signing algorithm based on the key, so the `build()` method no longer needs to provide that algorithm (though one can if they wish for things like RSA signatures if they want a different message digest in the signature).
>
> Jamil Nimeh has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Add more descriptive summary to test
>  - Merge with main
>  - Remove unnecessary throws declarations
>  - Fix JBS ID and summary in test
>  - 8349759: Fix CertificateBuilder and SimpleOCSPServer test utilities to support PQC algorithms

Looks good.

-------------

Marked as reviewed by mullan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23566#pullrequestreview-2634091549


More information about the core-libs-dev mailing list