RFR: 8349860: Make Class.isArray(), Class.isInterface() and Class.isPrimitive() non-native [v7]
Coleen Phillimore
coleenp at openjdk.org
Mon Feb 24 15:59:59 UTC 2025
On Thu, 20 Feb 2025 23:23:08 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>>> ... but not in the return since the caller likely will fetch the klass pointer next.
>>
>> I notice that too. Callers are using is_primitive() to short-circuit calls to as_Klass(), which means they seem to be aware of this implementation detail when maybe they shouldn't.
>
> There are 70 callers so yes, it might be something that shouldn't be known in this many places.
Definitely out of the scope of this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23572#discussion_r1967943222
More information about the core-libs-dev
mailing list