RFR: 8350594: Misleading warning about install dir for DMG packaging [v2]

[Alexander Matveev]

On Mon, 24 Feb 2025 18:19:12 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> - Fix the warning message about the custom installation directory location jpackage issues for DMG runtime packaging.
>>  - Don't issue the warning when the `-install-dir` value equals the default installation directory location.
>>  - Add relevant tests.
>
> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix bug with not running testDmg() tests

src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties line 94:

> 92: message.signing.pkg=Warning: For signing PKG, you might need to set "Always Trust" for your certificate using "Keychain Access" tool.
> 93: message.setfile.dmg=Setting custom icon on DMG file skipped because 'SetFile' utility was not found. Installing Xcode with Command Line Tools should resolve this issue.
> 94: message.install-dir-ignored=Warning: "--install-dir" is not supported by DMG and will be default to {0}.

I think it is better to change message to "Warning: "--install-dir" value "{0}" is not supported by DMG and will be default to {1}." Currently it sounds that CLI option "--install-dir" is not supported, but it will work if it points to default location.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23752#discussion_r1968497236