RFR: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException
Paul Sandoz
psandoz at openjdk.org
Tue Feb 25 00:02:53 UTC 2025
On Mon, 17 Feb 2025 06:40:11 GMT, Nicole Xu <duke at openjdk.org> wrote:
>> Please try with following command line
>> `java -jar target/benchmarks.jar -f 1 -i 2 -wi 1 -w 30 -p ARRAYLEN=30 MaskedLogic`
>
> Thanks for pointing that out. Typically, ARRAYLEN is almost always a POT value, which is also assumed by many other benchmarks. Are we realistically going to test with an ARRAYLEN of 30?
>
> I think the POT assumption is reasonable for our purposes.
It's a reasonable assumption. Since `ARRAYLEN` is a parameter of the benchmark we should enforce that constraint in benchmark initialization method, checking if the value is POT and failing otherwise.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22963#discussion_r1968595640
More information about the core-libs-dev
mailing list