RFR: 8350594: Misleading warning about install dir for DMG packaging [v2]

[Alexander Matveev]

On Tue, 25 Feb 2025 01:00:31 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties line 94:
>> 
>>> 92: message.signing.pkg=Warning: For signing PKG, you might need to set "Always Trust" for your certificate using "Keychain Access" tool.
>>> 93: message.setfile.dmg=Setting custom icon on DMG file skipped because 'SetFile' utility was not found. Installing Xcode with Command Line Tools should resolve this issue.
>>> 94: message.install-dir-ignored=Warning: "--install-dir" is not supported by DMG and will be default to {0}.
>> 
>> I think it is better to change message to "Warning: "--install-dir" value "{0}" is not supported by DMG and will be default to {1}." Currently it sounds that CLI option "--install-dir" is not supported, but it will work if it points to default location.
>
>> Currently it sounds that CLI option "--install-dir" is not supported, but it will work if it points to default location.
> 
> The warning will be shown only if `--install-dir` doesn't point to the default location. This is the change from the current behavior when the warning is shown if the `--install-dir` option is present on the command line regardless of its value.
> 
> If they pass `--install-dir /Applications` they will not see the warning.
> If they pass, say `--install-dir /opt` they will see the warning. Currently, it will be:
> 
> Warning: "--install-dir" is not supported by DMG and will be default to /Applications.
> 
> 
> Do you prefer:
> 
> Warning: "--install-dir" value "/opt" is not supported by DMG and will be default to /Applications.
> 
> ?
> 
> If we want to improve the warning text additionally to making it accurate for runtime packaging, I'd rather have this wording:
> 
> Warning: "--install-dir" option is ignored for DMG packaging. The installation directory will default to {0}.

I like this one and yes lets change it: `Warning: "--install-dir" option is ignored for DMG packaging. The installation directory will default to {0}.`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23752#discussion_r1968650421