RFR: 8350601: Miscellaneous updates to jpackage test lib [v3]
Alexey Semenyuk
asemenyuk at openjdk.org
Tue Feb 25 15:48:29 UTC 2025
On Tue, 25 Feb 2025 01:14:05 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>>> This one is confusing. It will evaluate to true if both != null
>>
>> Correct. They both shouldn't be `true`. One of them must be `true`, and another one must be `false`.
>>
>>> Did you mean "&&" instead of "=="?
>>
>> No. I meant `==` :)
>
> If they both set to non-null value, then exception will be thrown since false == false. In this case exception message is confusing. Maybe change it to: `Only one of `expectedPath` and `expectedExceptionClass` should be set`
Fixed as suggested
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23754#discussion_r1970049352
More information about the core-libs-dev
mailing list