Integrated: 8326447: jpackage creates Windows installers that cannot be signed

[Alexey Semenyuk]

On Sat, 22 Feb 2025 00:20:29 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

> Support the use of a custom msi wrapper executable when building an exe installer.
> 
> Put `installer.exe` file in the resource directory and jpackage will use it instead of the default `msiwrapper.exe` resource for exe installer.
> 
> To test this feature created a test that builds exe installer with a custom icon. The result installer exe is used as a custom msi wrapper executable in the second jpackage command that builds exe installer with the default icon. The installer exe produced by the second jackage command should have the same icon as the exe installer created in the first jpackage run.
> 
> Moved code verifying icons in executables from `LauncherIconVerifier.WinIconVerifier` class into `WinExecutableIconVerifier` class to make it available for tests. Replaced inline powershell script extracting icons from executables with standalone `read-executable-icon.ps1` powershell script. The script uses `ExtractIcon` instead of `ExtractAssociatedIcon`. It extracts icon from the executable's resources and will not fall back to anything if there is no icon resource.

This pull request has now been integrated.

Changeset: 267d69be
Author:    Alexey Semenyuk <asemenyuk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/267d69bed6265ec2820f17eb7534ec64d80ad093
Stats:     656 lines in 7 files changed: 457 ins; 193 del; 6 mod

8326447: jpackage creates Windows installers that cannot be signed

Reviewed-by: almatvee

-------------

PR: https://git.openjdk.org/jdk/pull/23732