RFR: 8350594: Misleading warning about install dir for DMG packaging [v3]

[Michael Hall]

> On Feb 26, 2025, at 3:59 PM, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
> 
> On Tue, 25 Feb 2025 16:14:22 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
> 
>>> - Fix the warning message about the custom installation directory location jpackage issues for DMG runtime packaging.
>>> - Don't issue the warning when the `--install-dir` value equals the default installation directory location.
>>> - Add relevant tests.
>> 
>> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>  Better warning wording
> 
> Are there any strong objections against showing the warning only when `--install-dir` is set to the non-default value for DMG packaging?
> 
> -------------
> 
> PR Comment: https://git.openjdk.org/jdk/pull/23752#issuecomment-2686296919

Thank you for helping me to understand the issue.

My opinion would still be that the warning should always be used since the parameter isn’t valid in this usage and not doing anything. If my understanding is in fact correct. Not a strong objection though.

After seeing this I was somewhat curious about the runtime packaging you mentioned.

The only reference I came across on some quick googling was here…

https://www.herongyang.com/Java-Tools/jpackage-What-Is-It.html

I copied my current /Library/Java/JavaVirtualMachines/jdk-22.0.1.jdk to a rt directory and ran…

jpackage -n rt -t dmg --runtime-image rt

The resulting dmg had 

ls /Volumes/rt/rt/Contents/Home
jdk-22.0.1.jdk

The actual runtime image is a couple directories deep. I tried removing my jdk22 and putting this into JavaVirtualMachines and it didn’t find it. 

/usr/libexec/java_home
/Library/Java/JavaVirtualMachines/jdk-22.0.1.jdk/Contents/Home

Or 

java -version
openjdk version "21.0.1" 2023-10-17
OpenJDK Runtime Environment (build 21.0.1+12-29)
OpenJDK 64-Bit Server VM (build 21.0.1+12-29, mixed mode, sharing)

Given the original dmg directory structure I tried…

jpackage -n rt -t dmg --runtime-image rt/jdk-22.0.1.jdk/Contents/Home

For some reason this dmg would’t open.

Is my usage incorrect or dmg not actually the type that should be used for this?





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/core-libs-dev/attachments/20250226/281c5bb9/attachment-0001.htm>