RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v2]

[Thomas Schatzl]

On Thu, 27 Feb 2025 18:31:16 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   * remove unnecessarily added logging
>
> src/hotspot/share/gc/g1/g1RemSet.cpp line 1252:
> 
>> 1250:     G1ConcurrentRefineWorkState::snapshot_heap_into(&constructed);
>> 1251:     claim = &constructed;
>> 1252:   }
> 
> It's not super obvious to me why the "has_sweep_claims" checking needs to be on this level. Can `G1ConcurrentRefineWorkState` return a valid `G1CardTableClaimTable*` directly?

I agree. I remember having similar thoughts as well, but then did not do anything about this. Will fix.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23739#discussion_r1975311607