RFR: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR [v2]

[Matthias Baesken]

On Thu, 27 Feb 2025 10:19:51 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> While testing a bit with a minimal JVM, it has been noticed that some java/lang jtreg tests use jfr but do not declare it with a "requires vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   copyright years

Regarding the requires tags of the tests, I looked a bit more into the jdk :tier1 tests  (when executed with a minimal JVM).
There are  ~ 30  com/sun/jdi  tests failing - guess they need the jvmti  JVM feature and miss the tag, correct  ?

Then there are a few like like
java/util/concurrent/locks/Lock/TimedAcquireLeak.java
java/lang/Class/GetPackageBootLoaderChildLayer.java
jdk/java/util/logging/TestLoggerWeakRefLeak.java
running into this exception

Exception in thread "main" com.sun.tools.attach.AttachNotSupportedException: The VM does not support the attach mechanism
	at jdk.attach/sun.tools.attach.HotSpotAttachProvider.testAttachable(HotSpotAttachProvider.java:134)
	at jdk.attach/sun.tools.attach.AttachProviderImpl.attachVirtualMachine(AttachProviderImpl.java:54)
	at jdk.attach/com.sun.tools.attach.VirtualMachine.attach(VirtualMachine.java:201)
	at jdk.jcmd/sun.tools.jmap.JMap.executeCommandForPid(JMap.java:127)
	at jdk.jcmd/sun.tools.jmap.JMap.histo(JMap.java:199)
	at jdk.jcmd/sun.tools.jmap.JMap.main(JMap.java:112)


Is here also jvmti required or is it some other JVM feature ?

Btw. I also added as an experiment    JVM feature 'management' to the minimal configuration.
This makes only ~ 1% size difference , on my Linux test system 6272144 (normal minimal) vs. 6337680 (minimal + management added), but helps a lot of jtreg tests because java management is needed across tests and jtreg itself; considering the very small difference it might make sense to add it to default 'minimal' config.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23805#issuecomment-2690724840