RFR: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method [v9]

[David Beaumont]

On Fri, 28 Feb 2025 09:28:29 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix @implNote to @apiNote.
>
> src/java.logging/share/classes/java/util/logging/StreamHandler.java line 240:
> 
>> 238:     void synchronousPostWriteHook() {
>> 239:         // Empty by default.
>> 240:     }
> 
> It would be good to have a comment making it clear that this method is called while holding the monitor on this. I know we have a test for that - but it could be good to make it clear in the code as well.
> What about:
> Suggestion:
> 
>     void synchronousPostWriteHook() {
>         // Empty by default. We could do:
>         //    assert Thread.holdsLock(this);
>         // but this is already covered by unit tests.
>     }

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23491#discussion_r1975483969