Integrated: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive

[Taizo Kurashige]

On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use  Cygwin’s `df` to get the size for comparison if the test target drive is a CD-ROM drive.
> 
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information about the size of the CD-ROM drive. 
> GetDiskFreeSpaceExW can also get information about the size of the CD-ROM drive. However, because GetDiskFreeSpaceExW is called by the File.get-X-Space methods, it seems more reasonable to compare the size got by other way than GetDiskFreeSpaceExW as a test. For this reason, I use Cygwin's `df`.
> In JDK-8298619, GetDiskSpaceInformationW was adopted instead of `df` because the size got by File.get-X-Space methods may not match the size got by `df` when per-user quotas are used. I don't think this problem applies to CD-ROM  drive, so I think we can use Cygwin's `df` for CD-ROM drive.
> 
> After fix, I ran a test on Windows Server 2019 where drive C is a normal local disk, drive D is an unmounted iso CD-ROM  drive, and drive F is an iso mounted CD-ROM drive and confirmed that it passes.
> 
> I think this fix may also resolves the similar failure reported at https://github.com/openjdk/jdk/pull/12397#issuecomment-1705164515.
> 
> Thanks

This pull request has now been integrated.

Changeset: 40f0a398
Author:    Taizo Kurashige <taizousum11 at gmail.com>
URL:       https://git.openjdk.org/jdk/commit/40f0a398fa9b1b39a43640973eaffb041bb7b63d
Stats:     80 lines in 2 files changed: 75 ins; 0 del; 5 mod

8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive

Reviewed-by: bpb, aturbanov

-------------

PR: https://git.openjdk.org/jdk/pull/21799