RFR: 8345782: Refining the cases that libjsig deprecation warning is issued [v2]

Joakim Nordström jnordstrom at openjdk.org
Wed Jan 8 11:03:06 UTC 2025


On Tue, 7 Jan 2025 14:26:13 GMT, Joakim Nordström <jnordstrom at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/signal/SigTestDriver.java line 176:
>> 
>>> 174:     /**
>>> 175:      * Return true for all signals used by the JVM. This only covers the
>>> 176:      * case where the JVM is started normally, and not with -Xrs.
>> 
>> The VM also uses SIGUSR2 (`SR_signum`), SIGINT, and SIGQUIT. Though the latter two only if no `-Xrs` is given.
>
> The test is skipped for SIGUSR2 on Linux and MacOS, and Windows skips all signal testing. So I guess that leaves aix, which seems to use signals_poxis.cpp... so perhaps the SIGUSR2 test should be skipped for aix too?
> But I'll add the signals for clarity.

Just to add to this, "aix" is explicitly skipped in the TestSigsur2.java test. So this test is never run for SIGUSR2.

I changed the comment for the method to indicate better what it returns.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22806#discussion_r1907003799


More information about the core-libs-dev mailing list