RFR: 8347124: Clean tests with --enable-linkable-runtime [v3]

Aleksey Shipilev shade at openjdk.org
Thu Jan 9 10:20:38 UTC 2025


On Thu, 9 Jan 2025 10:18:35 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this trivial test-only patch in support of running tests on JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run `jlink` in-process of the test JVM which includes module patches (as in - uses `--patch-module`) which is not supported for JEP 493 enabled JDKs. The proposed fix is to run those two tests in `/othervm` so as to no longer see the module patch of the test JDK.
>> 
>> Testing:
>> - [x] GHA
>> - [x] Affected tests which fail prior the patch and pass after with a JEP 493 enabled JDK. Also tested on a JDK that includes `jmods` folder.
>> 
>> Thoughts?
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Expand comment

Looks fine to me.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22969#pullrequestreview-2539455608


More information about the core-libs-dev mailing list