RFR: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected"
Joachim Kern
jkern at openjdk.org
Thu Jan 9 10:40:51 UTC 2025
On Wed, 8 Jan 2025 12:21:21 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> > The /proc//psinfo file is evaluated to obtain the cpu time
>
> Do you mean` /proc/<pid>/psinfo` ?
Strange, the < pid > is there, but not displayed, maybe interpreted as special characters.
I let the string interpreted as code. This helps.
> Looks reasonable to me. One question, do we still need unix_getParentPidAndTimings ? Seems we called it only from ProcessHandleImpl_aix.c , see a grep on the old codebase before your change
>
> ```
> java.base/aix/native/libjava/ProcessHandleImpl_aix.c:165: return unix_getParentPidAndTimings(env, pid, total, start);
> java.base/unix/native/libjava/ProcessHandleImpl_unix.c:98: * implementations simply call back to unix_getParentPidAndTimings() and
> java.base/unix/native/libjava/ProcessHandleImpl_unix.c:641:pid_t unix_getParentPidAndTimings(JNIEnv *env, pid_t pid,
> java.base/unix/native/libjava/ProcessHandleImpl_unix.h:59:extern pid_t unix_getParentPidAndTimings(JNIEnv *env, pid_t pid,
> ```
Seems, that we were the only remainding users of unix_getParentPidAndTimings(). Should I remove the orphant?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22966#issuecomment-2577559292
PR Comment: https://git.openjdk.org/jdk/pull/22966#issuecomment-2577593048
More information about the core-libs-dev
mailing list