RFR: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected" [v2]

[Joachim Kern]

On Thu, 9 Jan 2025 10:29:32 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Joachim Kern has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - remove extra white space
>>  - omit unused variable
>
> src/java.base/aix/native/libjava/ProcessHandleImpl_aix.c line 167:
> 
>> 165:     pid_t the_pid = pid;
>> 166:     struct procentry64 ProcessBuffer;
>> 167:     struct fdsinfo64 FileDescBuffer;
> 
> How is `FileDescBuffer` used? I can only see its size used. Wouldn't using `sizeof(fdsinfo64)` below be better?

I removed `FileDescBuffer` and replaced `sizeof(FileDescBuffer)` by `sizeof(struct fdsinfo64)`. 
`sizeof(fdsinfo64)` produces syntax errors

> src/java.base/aix/native/libjava/ProcessHandleImpl_aix.c line 169:
> 
>> 167:     struct fdsinfo64 FileDescBuffer;
>> 168: 
>> 169:     if (getprocs64(&ProcessBuffer, sizeof(ProcessBuffer), NULL, sizeof(FileDescBuffer), &the_pid, 1 ) <= 0) {
> 
> Extra whitespace before `)`.

Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22966#discussion_r1908617187
PR Review Comment: https://git.openjdk.org/jdk/pull/22966#discussion_r1908620205