RFR: 8303884: jlink --add-options plugin does not allow GNU style options to be provided [v3]

[Alan Bateman]

On Wed, 8 Jan 2025 00:40:04 GMT, Henry Jen <henryjen at openjdk.org> wrote:

>> Improving option value handling to support passing argument value starts with "--".
>> 
>> Before the fix, in following example, --add-modules will be considered as another option for JLink instead of argument value for --add-options.
>> --add-options --add-modules=jdk.incubator.concurrent
>> --add-options=--add-modules=jdk.incubator.concurrent
>> 
>> will cause JLink to report
>> Error: no value given for --add-options
>> as --add-modules is considered another option for JLink.
>> 
>> After the fix, by using = will ensure the value is properly handled as argument value
>> --add-options=--add-modules=jdk.incubator.concurrent
>
> Henry Jen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'openjdk/master' into JDK-8303884
>  - Use opt=value format when value is starting with --
>  - Fix style
>  - add test
>  - 8303884: jlink --add-options plugin does not allow GNU style options to be provided

Good, I like this too. I agree with Mandy on documenting this. Also to avoid developer flapping around trying to figure this out then maybe we need a better err.missing.arg resource when potentiallyGnuOption and the param starts with "--". In otherwise, could be just given a better error message?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22526#issuecomment-2582331118