RFR: 8347270: Remove unix_getParentPidAndTimings, unix_getChildren and unix_getCmdlineAndUserInfo [v2]
Christoph Langer
clanger at openjdk.org
Fri Jan 10 11:04:42 UTC 2025
On Fri, 10 Jan 2025 10:43:35 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an implementation that was shared between Solaris and AIX. Linux and MacOS already had specific implementations. After the removal of the Solaris port, these two functions can be removed in favor of inline implementations of os_getParentPidAndTimings and os_getCmdlineAndUserInfo in src/java.base/aix/native/libjava/ProcessHandleImpl_aix.c.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> remove unix_getChildren, adjust COPYRIGHT info
Marked as reviewed by clanger (Reviewer).
src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c line 81:
> 79: * ProcessHandleImpl_<os>.c file.
> 80: *
> 81: * Example :
Suggestion:
* Example:
-------------
PR Review: https://git.openjdk.org/jdk/pull/23013#pullrequestreview-2542158411
PR Review Comment: https://git.openjdk.org/jdk/pull/23013#discussion_r1910213004
More information about the core-libs-dev
mailing list