RFR: 8342466: Improve API documentation for java.lang.classfile.attribute
Chen Liang
liach at openjdk.org
Fri Jan 10 19:37:40 UTC 2025
On Fri, 10 Jan 2025 12:15:33 GMT, Adam Sotona <asotona at openjdk.org> wrote:
>> Improve documentation for `class` file attributes. This include better specification for user attributes, some more general information about attributes, such as the usage of non-JVMS attributes, and updated some attribute information in the base package too, such as Annotation and Signature.
>>
>> APIDiff: https://cr.openjdk.org/~liach/apidiff/cf-attribute/
>> Javadoc: https://cr.openjdk.org/~liach/javadoc/cf-attribute/java.base/java/lang/classfile/Attribute.html
>
> src/java.base/share/classes/java/lang/classfile/attribute/ModuleExportInfo.java line 71:
>
>> 69: * flag enums}
>> 70: *
>> 71: * @throws IllegalArgumentException if the flags mask has any unused bit set
>
> I'm not sure "if the flags mask has any unused bit set" is clear to understand
I think I will call it "undefined bit set". Is that more clear?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23026#discussion_r1911103619
More information about the core-libs-dev
mailing list