RFR: 8303884: jlink --add-options plugin does not allow GNU style options to be provided [v4]

[Alan Bateman]

On Mon, 13 Jan 2025 18:19:59 GMT, Henry Jen <henryjen at openjdk.org> wrote:

>> Improving option value handling to support passing argument value starts with "--".
>> 
>> Before the fix, in following example, --add-modules will be considered as another option for JLink instead of argument value for --add-options.
>> --add-options --add-modules=jdk.incubator.concurrent
>> --add-options=--add-modules=jdk.incubator.concurrent
>> 
>> will cause JLink to report
>> Error: no value given for --add-options
>> as --add-modules is considered another option for JLink.
>> 
>> After the fix, by using = will ensure the value is properly handled as argument value
>> --add-options=--add-modules=jdk.incubator.concurrent
>
> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use different error message for ambiguous gnu-style options as value

The update looks good, I assume you'll bump the copyright date of the files before integrating.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22526#pullrequestreview-2547498940