RFR: 8225763: Inflater and Deflater should implement AutoCloseable [v15]

Chen Liang liach at openjdk.org
Tue Jan 14 08:31:39 UTC 2025


On Tue, 14 Jan 2025 08:18:57 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix javadoc tag ordering - "@throws" after "@return"
>
> src/java.base/share/classes/java/util/zip/Deflater.java line 66:
> 
>> 64:  * {@code try}-with-resources statement. The {@linkplain Deflater#close() close() method} simply
>> 65:  * calls {@code end()}. Subclasses should override {@linkplain #end()} to clean up the
>> 66:  * resources acquired by the subclass.
> 
> I wonder if the note for subclasses should move to the end method as implSpec, it looks out of place in the class API note.

I believe an `@implSpec` only restricts the implementation of this immediate method, such as those seen on default methods, and has no impact on the overrides. If we need to specify something for overrides to abide to, I believe they usually stay in the API specification itself.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19675#discussion_r1914425192


More information about the core-libs-dev mailing list