RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v9]

Emanuel Peter epeter at openjdk.org
Tue Jan 14 08:41:46 UTC 2025


On Tue, 14 Jan 2025 08:29:25 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Galder Zamarreño has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make sure it runs with cpus with either avx512 or asimd
>
> test/hotspot/jtreg/compiler/loopopts/superword/MinMaxRed_Long.java line 104:
> 
>> 102:     }
>> 103: 
>> 104:     public static void ReductionInit(long[] longs, int probability) {
> 
> Suggestion:
> 
>     public static void reductionInit(long[] longs, int probability) {
> 
> This is a method name, not a class - so I think it should start lower-case, right?

And the method might as well allocate the array too. But up to you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20098#discussion_r1914427359


More information about the core-libs-dev mailing list