RFR: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing [v2]

Brian Burkhalter bpb at openjdk.org
Wed Jan 15 17:01:43 UTC 2025


On Wed, 15 Jan 2025 07:19:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8347740: Minor clean up
>
> test/jdk/java/io/File/createTempFile/SpecialTempFile.java line 117:
> 
>> 115: 
>> 116:         String[] nameElements = osName.split(" ");
>> 117:         int nameVers = Integer.valueOf(nameElements[nameElements.length - 1]);
> 
> That may work with current versions but be aware we sometimes have things like "Server 2012 R2"

Thanks. Yes, I looked at various references including [Wikipedia](https://en.wikipedia.org/wiki/List_of_Microsoft_Windows_versions). It could use some refinement, probably, or perhaps the Windows-specific of the test could simply be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23117#discussion_r1917025355


More information about the core-libs-dev mailing list