RFR: 8347408: Create an internal method handle adapter for system calls with errno [v14]
Per Minborg
pminborg at openjdk.org
Thu Jan 16 10:20:37 UTC 2025
On Wed, 15 Jan 2025 16:13:38 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Use invokeExact semantics in the tests
>> - Clean up
>
> src/java.base/share/classes/jdk/internal/foreign/CaptureStateUtil.java line 288:
>
>> 286:
>> 287: // Using an int lock is faster than CASing a reference field
>> 288: private int lock;
>
> can this be a `boolean`? Or, maybe keep the int, but declare useful static constants, like "READY", "IN_USE" etc.
`int` is the fastest. I've tried `boolean`, `byte` and `short` as well. I will add constants.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22391#discussion_r1918192669
More information about the core-libs-dev
mailing list