RFR: 8343962: [REDO] Move getChars to DecimalDigits [v6]

[Shaojin Wen]

On Thu, 16 Jan 2025 17:22:50 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 19 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into int_get_chars_dedup_202411
>>  - form @cl4es
>>  - Merge remote-tracking branch 'upstream/master' into int_get_chars_dedup_202411
>>  - Merge remote-tracking branch 'upstream/master' into int_get_chars_dedup_202411
>>  - Merge remote-tracking branch 'upstream/master' into int_get_chars_dedup_202411
>>  - fix unsafe address overflow
>>  - add benchmark
>>  - remove comments, from @liach
>>  - Merge remote-tracking branch 'upstream/master' into int_get_chars_dedup_202410
>>  - fix Helper
>>  - ... and 9 more: https://git.openjdk.org/jdk/compare/2ec55f08...8122c1bf
>
> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 42:
> 
>> 40: 
>> 41:     /**
>> 42:      * Each element of the array represents the packaging of two ascii characters based on little endian:<p>
> 
> The table below contradicts itself.
> For example
> 
>      *      02 -> '2' | ('0' << 8) -> 0x3230
> 
> should instead read
> 
>      *      02 -> '2' | ('0' << 8) -> 0x3032
> 
> and so on.
> 
> Please adjust the comment and check that everything related to `DIGITS` is used consistently.

fixed it

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22023#discussion_r1919387362