RFR: 8338428: Add logging if final VM flags while setting properties [v5]
Leonid Mesnik
lmesnik at openjdk.org
Fri Jan 17 19:17:36 UTC 2025
On Fri, 17 Jan 2025 17:27:32 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
> This seems like overkill for a weak use case.
>
> The resulting log file is in the scratch directory so it will not be retained for long. In local builds, whoever is running the test could add the arguments.
Thanks for your feedback.
Currently, typical size of artifacts for *passed* run take a tens of MB, so it is less then 0.5% increase. The main consumer are .jtr files.
>
> Have there been any negative interactions with any of the test tiers due to the addition of extra logging flags?
Which negative interactions you suppose? This fix shouldn't interfere with executed tests completely.
The only restriction is that we shouldn't use added
XX:+LogVMOutput -XX:-DisplayVMOutput -XX:LogFile
in VMProps to calclulate their final values.
However, they are not used in \requires` at all.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23054#issuecomment-2599032748
More information about the core-libs-dev
mailing list