RFR: 8347949: Currency method to stream available Currencies [v2]

Justin Lu jlu at openjdk.org
Fri Jan 17 22:39:14 UTC 2025


On Fri, 17 Jan 2025 22:11:51 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   synchronize init method over block
>
> src/java.base/share/classes/java/util/Currency.java line 467:
> 
>> 465:     private static synchronized void initAvailableCurrencies() {
>> 466:         if (available == null) {
>> 467:             available = new HashSet<>(256);
> 
> Not related to your change, but this should be `HashSet.newHashSet(256)`. In fact 256*0.75 is 192, which is smaller than the current number of currencies (230, as of JDK24)

Fixed in https://github.com/openjdk/jdk/pull/23165/commits/c94ba9447cf3d24ba6e4162890a9be5d611dbfa7

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23165#discussion_r1920836146


More information about the core-libs-dev mailing list