RFR: 8343962: [REDO] Move getChars to DecimalDigits [v8]

[Raffaello Giulietti]

On Tue, 14 Jan 2025 04:08:28 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix comment
>
> Always good to see some methods removed from `JavaLangAccess` - but it appears these are already unused?
> 
> I think the performance gain from this is somewhat underwhelming. `Unsafe` is a big hammer to eek out ~10% performance in an isolated code path.
> 
> And perhaps it would be better to just push the microbenchmark, any code cleanups (like the removal of unused methods from JavaLangAccess) and leave code unchanged and leave it as a challenge for JIT engineers to get the pre-existing code to parity with this `Unsafe` routine.
> 
> That said I'm ok with this as is but will request a second opinion. Maybe @rgiulietti can weigh in?

@cl4es FYI, the changes introduced since the commit you approved are just cosmetic and stylistic. The only notable modification is the use of `Unsafe::putCharUnaligned`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22023#issuecomment-2606867180