RFR: 8348348: Remove unnecessary #ifdef STATIC_BUILD around DEF_STATIC_JNI_OnLoad from zip_util.c

Jiangli Zhou jiangli at openjdk.org
Tue Jan 28 16:36:46 UTC 2025


On Tue, 28 Jan 2025 16:24:57 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this trivial cleanup that removes the #ifdef STATIC_BUILD around DEF_STATIC_JNI_OnLoad from zip_util.c. Thanks.
>
> Looks good. `DEF_STATIC_JNI_OnLoad` will do the right thing based on the `STATIC_BUILD` define here:
> https://github.com/openjdk/jdk/blob/fb066caea8a6bbf5b7a6fbe1ca51282e2c7c1ff2/src/java.base/share/native/libjava/jni_util.h#L364-L414

Thanks for the review, @jerboaa!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23247#issuecomment-2619507052


More information about the core-libs-dev mailing list